Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdFIXra (ORCPT ); Fri, 9 Jun 2017 19:47:30 -0400 Received: from mga03.intel.com ([134.134.136.65]:24831 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbdFIXr2 (ORCPT ); Fri, 9 Jun 2017 19:47:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,320,1493708400"; d="scan'208";a="113130987" From: "Mani, Rajmohan" To: Hans de Goede , Sakari Ailus , Andy Shevchenko CC: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Lee Jones , Linus Walleij , "Alexandre Courbot" , "Rafael J. Wysocki" , "Len Brown" Subject: RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Thread-Topic: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Thread-Index: AQHS3rzEYU7jz9+9JUK4AveyJYX8GqIYWO4AgAFuVACAABfKgIAAbSWAgAC2cQCAAjUH8A== Date: Fri, 9 Jun 2017 23:47:25 +0000 Message-ID: <6F87890CF0F5204F892DEA1EF0D77A59725BED29@FMSMSX114.amr.corp.intel.com> References: <1496750118-5570-1-git-send-email-rajmohan.mani@intel.com> <1496750118-5570-4-git-send-email-rajmohan.mani@intel.com> <20170607121503.GA1019@valkosipuli.retiisi.org.uk> <20170607201050.GE1019@valkosipuli.retiisi.org.uk> <00ae0f71-a83e-ff54-eaad-77e835e1dba7@redhat.com> In-Reply-To: <00ae0f71-a83e-ff54-eaad-77e835e1dba7@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v59NlXna019168 Content-Length: 1207 Lines: 26 Hi Hans, > > > > As PMICs are typically linked to the kernel (vs. being modules), > > there's no issue with the module name. I would suppose few if any > > PMICs will be compiled as modules in general. > > Good point about the OpRegion driver usually being built-in, in my experience it > MUST always be built-in, so the Kconfig option should be a bool. Note this is > useless unless the mfd driver is also a bool (I would advice to go that > route) and the mfd driver's Kconfig should select the right i2c bus driver to > make sure that is built-in too, see for example: > > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for- > mfd-next&id=2f91ded5f8f4fdd67d8daae514b0d434c98ab1e0 > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for- > mfd-next&id=c5065d8625ebdc164199b99d838ac0636faa7f0b > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for- > mfd-next&id=5f125f1f570568a29edf783fba1ebb606d5c6b24 > > Which are all recent commits from me dealing with making the mfd driver built- > in / selecting the i2c bus driver. > Thanks for these links. I will update the Kconfig and commit messages with relevant description around this.