Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751651AbdFIX4y (ORCPT ); Fri, 9 Jun 2017 19:56:54 -0400 Received: from ozlabs.org ([103.22.144.67]:52891 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbdFIX4w (ORCPT ); Fri, 9 Jun 2017 19:56:52 -0400 Date: Sat, 10 Jun 2017 09:56:49 +1000 From: Stephen Rothwell To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Rob Herring , Jiri Slaby Subject: Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type Message-ID: <20170610095649.2731e8fb@canb.auug.org.au> In-Reply-To: <20170606192221.1617-16-gregkh@linuxfoundation.org> References: <20170606192221.1617-1-gregkh@linuxfoundation.org> <20170606192221.1617-16-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 774 Lines: 28 Hi Greg, On Tue, 6 Jun 2017 21:22:20 +0200 Greg Kroah-Hartman wrote: > > -static struct device_attribute serdev_device_attrs[] = { > - __ATTR_RO(modalias), > - __ATTR_NULL > +static struct attribute *serdev_device_attrs[] = { ^^^^^^^^^^^^^^^^^^^ Should have been "serdev_device_groups" > + &dev_attr_modalias.attr, > + NULL, > }; > +ATTRIBUTE_GROUPS(serdev_device); > > static struct bus_type serdev_bus_type = { > .name = "serial", > @@ -262,7 +264,7 @@ static struct bus_type serdev_bus_type = { > .probe = serdev_drv_probe, > .remove = serdev_drv_remove, > .uevent = serdev_uevent, > - .dev_attrs = serdev_device_attrs, > + .dev_groups = serdev_device_groups, > }; -- Cheers, Stephen Rothwell