Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbdFJAB0 (ORCPT ); Fri, 9 Jun 2017 20:01:26 -0400 Received: from ozlabs.org ([103.22.144.67]:41555 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbdFJABZ (ORCPT ); Fri, 9 Jun 2017 20:01:25 -0400 Date: Sat, 10 Jun 2017 10:01:22 +1000 From: Stephen Rothwell To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Rob Herring , Jiri Slaby Subject: Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type Message-ID: <20170610100122.303cc2dd@canb.auug.org.au> In-Reply-To: <20170610095649.2731e8fb@canb.auug.org.au> References: <20170606192221.1617-1-gregkh@linuxfoundation.org> <20170606192221.1617-16-gregkh@linuxfoundation.org> <20170610095649.2731e8fb@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 20 Hi Greg, On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell wrote: > > > +static struct attribute *serdev_device_attrs[] = { > ^^^^^^^^^^^^^^^^^^^ > Should have been "serdev_device_groups" Sorry, my mistake. > > + &dev_attr_modalias.attr, > > + NULL, > > }; > > +ATTRIBUTE_GROUPS(serdev_device); I really hate macros that create symbols by concatenating parts. :-( -- Cheers, Stephen Rothwell