Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbdFJKgo (ORCPT ); Sat, 10 Jun 2017 06:36:44 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:32961 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751918AbdFJKgm (ORCPT ); Sat, 10 Jun 2017 06:36:42 -0400 Subject: Re: [PATCH] usb: mtu3: Handle return value of clk_prepare_enable To: Arvind Yadav , gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <64498035baed409a32987e76838d19ccefe73c61.1497005619.git.arvind.yadav.cs@gmail.com> From: Matthias Brugger Message-ID: <3fc5d464-9772-7579-39ab-039e690f6cb9@gmail.com> Date: Sat, 10 Jun 2017 12:36:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <64498035baed409a32987e76838d19ccefe73c61.1497005619.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1572 Lines: 58 On 09/06/17 14:03, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/mtu3/mtu3_plat.c | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > Reviewed-by: Matthias Brugger > diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c > index 42550c7..0d3ebb3 100644 > --- a/drivers/usb/mtu3/mtu3_plat.c > +++ b/drivers/usb/mtu3/mtu3_plat.c > @@ -458,6 +458,7 @@ static int __maybe_unused mtu3_resume(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct ssusb_mtk *ssusb = platform_get_drvdata(pdev); > + int ret; > > dev_dbg(dev, "%s\n", __func__); > > @@ -465,12 +466,28 @@ static int __maybe_unused mtu3_resume(struct device *dev) > return 0; > > ssusb_wakeup_disable(ssusb); > - clk_prepare_enable(ssusb->sys_clk); > - clk_prepare_enable(ssusb->ref_clk); > - ssusb_phy_power_on(ssusb); > + ret = clk_prepare_enable(ssusb->sys_clk); > + if (ret) > + goto err_sys_clk; > + > + ret = clk_prepare_enable(ssusb->ref_clk); > + if (ret) > + goto err_ref_clk; > + > + ret = ssusb_phy_power_on(ssusb); > + if (ret) > + goto err_power_on; > + > ssusb_host_enable(ssusb); > > return 0; > + > +err_power_on: > + clk_disable_unprepare(ssusb->ref_clk); > +err_ref_clk: > + clk_disable_unprepare(ssusb->sys_clk); > +err_sys_clk: > + return ret; > } > > static const struct dev_pm_ops mtu3_pm_ops = { >