Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119AbdFJMwD (ORCPT ); Sat, 10 Jun 2017 08:52:03 -0400 Received: from mail-sn1nam01on0055.outbound.protection.outlook.com ([104.47.32.55]:1474 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751677AbdFJMwB (ORCPT ); Sat, 10 Jun 2017 08:52:01 -0400 From: "Mintz, Yuval" To: Salil Mehta , "davem@davemloft.net" CC: "yisen.zhuang@huawei.com" , "huangdaode@hisilicon.com" , "lipeng321@huawei.com" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxarm@huawei.com" Subject: RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Thread-Topic: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Thread-Index: AQHS4Zxs7mh9Tkxs50OK5k89pKt8wqIeDNIA Date: Sat, 10 Jun 2017 12:51:57 +0000 Message-ID: References: <20170610034630.493852-1-salil.mehta@huawei.com> <20170610034630.493852-9-salil.mehta@huawei.com> In-Reply-To: <20170610034630.493852-9-salil.mehta@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [31.168.140.228] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR0701MB2005;7:JeYV5FiO2V/ibBU+Cm1ilJbMLFeoZhjD77Wf0BiPNBhe005a1gE1QAOezCykoY/HnLWw5UNdI7a41SQXkbyPtvx2W+q6Ou+dpWk+a3czy+uH2PtTmAU7rOyKRSZMTrUi0Qfn3XYHoW/TWfdEhLEN6CfBHsKVAmOXndz6lE5F5/cC+8K7v5kgkTyfcNgtIK3q7ACMi3izHkKV/tVQxaczeg1ca50CMsh1Nnpv8bwOglcgVwmWISpo7+d6dXI5+Us8XdL+AIZE65Uvq/UKVKQxhxoUHm+1T/8ew1lLbIUUZHSOBfwV5Rlwo5pO1jRdFxQcn0BbhsOi5l9dmPNBlXVzRw== x-ms-traffictypediagnostic: BY2PR0701MB2005: x-ms-office365-filtering-correlation-id: a93fc7b4-f4a5-43a7-4452-08d4afff7aa3 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR0701MB2005; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR0701MB2005;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR0701MB2005; x-forefront-prvs: 0334223192 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39850400002)(39840400002)(39400400002)(39410400002)(25786009)(2501003)(102836003)(3846002)(6116002)(14454004)(54356999)(76176999)(3660700001)(3280700002)(50986999)(4326008)(7696004)(33656002)(39060400002)(7736002)(74316002)(72206003)(5660300001)(305945005)(55016002)(8936002)(478600001)(53936002)(9686003)(6246003)(99286003)(54906002)(122556002)(38730400002)(6436002)(229853002)(77096006)(2906002)(2900100001)(189998001)(8676002)(81166006)(66066001)(2950100002)(86362001)(6506006);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0701MB2005;H:BY2PR0701MB2005.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2017 12:51:57.3248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0701MB2005 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5ACqBaB009873 Content-Length: 371 Lines: 9 > This adds the support of the debugfs interface to the driver for debugging > purposes. > +const struct hclge_support_cmd support_cmd[] = { > + {"send cmd", 8, hclge_dbg_send, > + "opcode flag data0 data1 data2 data3 data4 data5"}, > + {"help", 4, hclge_dbg_usage, "no option"}, }; Is there an actual description of what this does? Or is it simply a huge backdoor?