Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbdFJQfq (ORCPT ); Sat, 10 Jun 2017 12:35:46 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:44227 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbdFJQfp (ORCPT ); Sat, 10 Jun 2017 12:35:45 -0400 Date: Sat, 10 Jun 2017 18:35:35 +0200 From: Andrew Lunn To: "Mintz, Yuval" Cc: Salil Mehta , "davem@davemloft.net" , "yisen.zhuang@huawei.com" , "huangdaode@hisilicon.com" , "lipeng321@huawei.com" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxarm@huawei.com" Subject: Re: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Message-ID: <20170610163535.GC26740@lunn.ch> References: <20170610034630.493852-1-salil.mehta@huawei.com> <20170610034630.493852-9-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 19 On Sat, Jun 10, 2017 at 12:51:57PM +0000, Mintz, Yuval wrote: > > This adds the support of the debugfs interface to the driver for debugging > > purposes. > > > +const struct hclge_support_cmd support_cmd[] = { > > + {"send cmd", 8, hclge_dbg_send, > > + "opcode flag data0 data1 data2 data3 data4 data5"}, > > + {"help", 4, hclge_dbg_usage, "no option"}, }; > > Is there an actual description of what this does? Or is it simply a huge backdoor? It looks like a huge backdoor to the chip. It is O.K. to have such a patch internally for your own development work, but it should not be submitted for mainline. NACK Andrew