Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbdFJTcm (ORCPT ); Sat, 10 Jun 2017 15:32:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:17194 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdFJTck (ORCPT ); Sat, 10 Jun 2017 15:32:40 -0400 Subject: Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe To: Suman Anna , Bjorn Andersson , Rob Herring , Ohad Ben-Cohen Cc: Santosh Shilimkar , Mark Rutland , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew F. Davis" , Sam Nelson References: <20170608002447.47580-1-s-anna@ti.com> <20170608002447.47580-4-s-anna@ti.com> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <6ce5952b-55b0-8f77-2e14-51110d6bf979@oracle.com> Date: Sat, 10 Jun 2017 12:32:43 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170608002447.47580-4-s-anna@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 585 Lines: 14 On 6/7/2017 5:24 PM, Suman Anna wrote: > From: "Andrew F. Davis" > > The DSPs are expected to be in reset when the driver probes a device. > If the DSPs are out of reset in probe, the system may crash when the > firmware is being loaded. So, add a check to make sure the DSP resets > are asserted, and if not, throw a eye-catchy warning and assert the > resets specifically. > > Signed-off-by: Andrew F. Davis > [s-anna@ti.com: replace warning with a WARN] > Signed-off-by: Suman Anna > --- Acked-by: Santosh Shilimkar