Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbdFJVn0 (ORCPT ); Sat, 10 Jun 2017 17:43:26 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59015 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdFJVnY (ORCPT ); Sat, 10 Jun 2017 17:43:24 -0400 X-ME-Sender: X-Sasl-enc: /nWlq97BftIiZ5BUkxIlQMzgaHmIiC456TegjBdevfxf 1497131003 Date: Sat, 10 Jun 2017 18:43:20 -0300 From: Henrique de Moraes Holschuh To: "Jason A. Donenfeld" Cc: Gilad Ben-Yossef , Linux kernel mailing list , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH 3/6] ccree: use constant time memory comparison for macs and tags Message-ID: <20170610214319.GA20743@khazad-dum.debian.net> References: <20170610025912.6499-1-Jason@zx2c4.com> <20170610025912.6499-4-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint1: 4096R/0x0BD9E81139CB4807: C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 453 Lines: 11 On Sat, 10 Jun 2017, Jason A. Donenfeld wrote: > That's fine. As I mentioned, I really have no clue what this code's > trying to do. If this is just part of some test that doesn't deal with > actual messages that could be forged, then of course there's nothing > that needs to be done and this can be NAKd. Well, it is *testing* things, so you might want to use whatever the module(s) will actually use. Maybe test with both? -- Henrique Holschuh