Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdFKK01 (ORCPT ); Sun, 11 Jun 2017 06:26:27 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:34678 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbdFKK00 (ORCPT ); Sun, 11 Jun 2017 06:26:26 -0400 MIME-Version: 1.0 In-Reply-To: <13f337ad-83ba-5542-0d6f-61282d2afce2@fau.de> References: <13f337ad-83ba-5542-0d6f-61282d2afce2@fau.de> From: Jonas Gorski Date: Sun, 11 Jun 2017 12:26:04 +0200 Message-ID: Subject: Re: [PATCH] regmap: make LZO cache optional To: Andreas Ziegler Cc: Mark Brown , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 24 Hi Andreas, On 8 June 2017 at 16:28, Andreas Ziegler wrote: > Hi Jonas, > > I noticed your patch 'regmap: make LZO cache optional' as it recently showed up > in linux-next. In your patch, you modify drivers/base/regmap/regcache.c by > adding an #if IS_ENABLED() statement. > > However, this statement contains a spelling error, as it references > REGCHACHE_COMPRESSED instead of REGCACHE_COMPRESSED (note the extra H). > > I noticed it by running the in-tree script at scripts/checkkconfigsymbols.py on > the commit, like so: './scripts/checkkconfigsymbols.py -c 34a730aa74c7' > > As Greg suggested the whole code could be dropped, this might not be too > relevant, but I wanted to let you know in any case. Thanks for spotting that, and I wasn't aware of this script, that seems quite useful! Regards Jonas