Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbdFKLYU (ORCPT ); Sun, 11 Jun 2017 07:24:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:37330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbdFKLYT (ORCPT ); Sun, 11 Jun 2017 07:24:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CA4D23698 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 11 Jun 2017 12:24:13 +0100 From: Jonathan Cameron To: Eugen Hristev Cc: , , , , , , , , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/4] Documentation: dt: iio: at91-sama5d2_adc: add hw trigger edge binding Message-ID: <20170611122413.20008d30@kernel.org> In-Reply-To: <1496992039-17964-3-git-send-email-eugen.hristev@microchip.com> References: <1496992039-17964-1-git-send-email-eugen.hristev@microchip.com> <1496992039-17964-3-git-send-email-eugen.hristev@microchip.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1841 Lines: 44 On Fri, 9 Jun 2017 10:07:17 +0300 Eugen Hristev wrote: > Add property for the edge type of the hardware trigger pin ADTRG > > Signed-off-by: Eugen Hristev Hi Eugen, CC the device tree maintainers and list for devicetree binding changes. I've added them. This one is unusual enough it will need and Ack from that direction (and I prefer to get them even for the trivial patches when Rob and Mark aren't too busy!) Jonathan > --- > Changes in v4: > - Modified bindings to be similar with interrupts > > Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt > index 3223684..552e7a8 100644 > --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt > @@ -11,6 +11,11 @@ Required properties: > - atmel,min-sample-rate-hz: Minimum sampling rate, it depends on SoC. > - atmel,max-sample-rate-hz: Maximum sampling rate, it depends on SoC. > - atmel,startup-time-ms: Startup time expressed in ms, it depends on SoC. > + - atmel,trigger-edge-type: One of possible edge types for the ADTRG hardware > + trigger pin. When the specific edge type is detected, the conversion will > + start. Possible values are rising, falling, or both. > + This property uses the IRQ edge types values: IRQ_TYPE_EDGE_RISING , > + IRQ_TYPE_EDGE_FALLING or IRQ_TYPE_EDGE_BOTH > > Example: > > @@ -25,4 +30,5 @@ adc: adc@fc030000 { > atmel,startup-time-ms = <4>; > vddana-supply = <&vdd_3v3_lp_reg>; > vref-supply = <&vdd_3v3_lp_reg>; > + atmel,trigger-edge-type = ; > }