Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbdFKNuV (ORCPT ); Sun, 11 Jun 2017 09:50:21 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:36619 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbdFKNuT (ORCPT ); Sun, 11 Jun 2017 09:50:19 -0400 MIME-Version: 1.0 In-Reply-To: <1497161395-36504-3-git-send-email-rajmohan.mani@intel.com> References: <1497161395-36504-1-git-send-email-rajmohan.mani@intel.com> <1497161395-36504-3-git-send-email-rajmohan.mani@intel.com> From: Andy Shevchenko Date: Sun, 11 Jun 2017 16:43:55 +0300 Message-ID: Subject: Re: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs To: Rajmohan Mani Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Lee Jones , Linus Walleij , Alexandre Courbot , "Rafael J. Wysocki" , Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 606 Lines: 16 On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani wrote: > This patch adds support for TPS68470 GPIOs. > There are 7 GPIOs and a few sensor related GPIOs. > These GPIOs can be requested and configured as > appropriate. Main points (some I already told in an answer to Sakari's mail): 1. Consider 2 GPIO chips over 1. 2. Fix FIXME(s). 3. If there is hardware bug we should work around it must be clarified. 4. You missed Linus' comments here (switch to the data pointer inside GPIO chip and remove platform driver data stuff from the driver). -- With Best Regards, Andy Shevchenko