Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbdFKTGf (ORCPT ); Sun, 11 Jun 2017 15:06:35 -0400 Received: from one.firstfloor.org ([193.170.194.197]:53994 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbdFKTGe (ORCPT ); Sun, 11 Jun 2017 15:06:34 -0400 Date: Sun, 11 Jun 2017 12:06:31 -0700 From: Andi Kleen To: Milian Wolff Cc: Andi Kleen , Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields Message-ID: <20170611190630.GI8096@two.firstfloor.org> References: <20170602154810.15875-1-andi@firstfloor.org> <4401931.mLE8BEDJl7@milian-kdab2> <20170609025243.GA28361@tassilo.jf.intel.com> <1677340.sCCOOhZNxQ@agathebauer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1677340.sCCOOhZNxQ@agathebauer> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 35 On Fri, Jun 09, 2017 at 11:13:11AM +0200, Milian Wolff wrote: > > > But I cannot do: > > > > > > $ perf record -e "topdown-*" ls > > > event syntax error: 'topdown-*' > > > > That's actually good because the current topdown events are not useful to > > sample > > Can you elaborate? I assume it's because you actually want to sample on > instructions, and then group it together with the topdown events and > potentially other counters like instructions? The topdown-* events are inputs to a formula. But you cannot directly sample for the formula. What you can do is to compute the formuals from counts, determine the bottlenecks and then sample for events which look for the bottlebeck. For example FRONTEND_* for Frontend Bound. These events are generally different. toplev in pmu-tools implements this automatically, but it's a bit too complicated for standard perf. > > > Usually you need to have at least some idea about the events you're > > collecting, and also for non trivial collections you need groups to get > > good results. > > Yes, sure. But replace `record` with `stat` in the above and my point still > stands The comment was for stat. -Andi