Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdFKUTU (ORCPT ); Sun, 11 Jun 2017 16:19:20 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35582 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbdFKUTQ (ORCPT ); Sun, 11 Jun 2017 16:19:16 -0400 MIME-Version: 1.0 In-Reply-To: References: <1497001756-942-1-git-send-email-narmstrong@baylibre.com> <1497001756-942-7-git-send-email-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Sun, 11 Jun 2017 22:18:54 +0200 Message-ID: Subject: Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes To: Neil Armstrong Cc: gregkh@linuxfoundation.org, khilman@baylibre.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hgkr.klein@gmail.com, linux-serial@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2901 Lines: 82 On Sat, Jun 10, 2017 at 12:37 AM, Martin Blumenstingl wrote: > Hi Neil, > > On Fri, Jun 9, 2017 at 11:49 AM, Neil Armstrong wrote: >> Switch to the stable UART bindings by adding a XTAL node and using the >> proper compatible strings. > unfortunately this won't apply now that Kevin has merged my "ARM: dts: > meson8: add and use the real clock controller" > on the other hand this will make the patch easier as you can now do > the same changes as in meson8b.dtsi Neil, if you want you could also drop this from your series and let me handle this (just let me know). I would even go one step further and export the CLKID_UART0, CLKID_UART1 and CLKID_UART2 gates and pass them as "pclk" for uart_{A,B,C} I'll even *try* to test if this works on real hardware (my Meson8m2 board has a RTL8723BS SDIO wifi + bluetooth chip - wifi driver support has been pretty bad so far - but I'll try to see if I can get and messages out of the bluetooth part) just let me know if you want me to handle this patch for you >> Signed-off-by: Neil Armstrong >> --- >> arch/arm/boot/dts/meson8.dtsi | 23 +++++++++++++++++++---- >> 1 file changed, 19 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi >> index 6993077..a2ea112 100644 >> --- a/arch/arm/boot/dts/meson8.dtsi >> +++ b/arch/arm/boot/dts/meson8.dtsi >> @@ -83,6 +83,13 @@ >> }; >> }; >> >> + xtal: xtal-clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + clock-output-names = "xtal"; >> + #clock-cells = <0>; >> + }; >> + >> clk81: clk@0 { >> #clock-cells = <0>; >> compatible = "fixed-clock"; >> @@ -199,17 +206,25 @@ >> }; >> >> &uart_AO { >> - clocks = <&clk81>; >> + compatible = "amlogic,meson8-uart", "amlogic,meson-ao-uart"; >> + clocks = <&xtal>, <&clk81>, <&clk81>; >> + clock-names = "xtal", "pclk", "baud"; >> }; >> >> &uart_A { >> - clocks = <&clk81>; >> + compatible = "amlogic,meson8-uart"; >> + clocks = <&xtal>, <&clk81>, <&clk81>; >> + clock-names = "xtal", "pclk", "baud"; >> }; >> >> &uart_B { >> - clocks = <&clk81>; >> + compatible = "amlogic,meson8-uart"; >> + clocks = <&xtal>, <&clk81>, <&clk81>; >> + clock-names = "xtal", "pclk", "baud"; >> }; >> >> &uart_C { >> - clocks = <&clk81>; >> + compatible = "amlogic,meson8-uart"; >> + clocks = <&xtal>, <&clk81>, <&clk81>; >> + clock-names = "xtal", "pclk", "baud"; >> }; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic