Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbdFKVyV (ORCPT ); Sun, 11 Jun 2017 17:54:21 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:59306 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbdFKVyT (ORCPT ); Sun, 11 Jun 2017 17:54:19 -0400 From: Chris Packham To: Ralph Sennhauser , Gregory CLEMENT CC: Linus Walleij , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jason Cooper , "Andrew Lunn" , Sebastian Hesselbarth , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Thread-Topic: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Thread-Index: AQHS4QiAcXLV7OMd8UGVch+cnukIRw== Date: Sun, 11 Jun 2017 21:54:14 +0000 Message-ID: <192e8364fed24e91a12b5dec78fa06f0@svr-chch-ex1.atlnz.lc> References: <20170609100917.26660-1-gregory.clement@free-electrons.com> <20170609142144.5f6c916b@gmail.com> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [2001:df5:b000:22:78c1:f648:bf50:be35] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5BLsPuG021933 Content-Length: 797 Lines: 25 On 10/06/17 00:22, Ralph Sennhauser wrote: > On Fri, 9 Jun 2017 12:09:17 +0200 > Gregory CLEMENT wrote: > >> In some place in the driver regmap_update_bits was misused. Indeed the >> last argument is not the value of the bit (or group of bits) itself >> but the mask value inside the register. >> >> So when setting the bit N, then the value must be BIT(N) and not 1. >> >> CC: Chris Packham >> CC: Ralph Sennhauser >> Signed-off-by: Gregory CLEMENT >> --- > > Hi Gregory, > > Tested-by: Ralph Sennhauser > > Thanks for the prompt fix > Ralph Also works for me Tested-by: Chris Packham