Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbdFLASe (ORCPT ); Sun, 11 Jun 2017 20:18:34 -0400 Received: from mga09.intel.com ([134.134.136.24]:50819 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbdFLASc (ORCPT ); Sun, 11 Jun 2017 20:18:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,331,1493708400"; d="scan'208";a="272961015" From: "Mani, Rajmohan" To: Linus Walleij CC: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "ACPI Devel Maling List" , Lee Jones , Alexandre Courbot , "Rafael J. Wysocki" , Len Brown Subject: RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs Thread-Topic: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs Thread-Index: AQHS3rzDQNsvvqbo1U++AaPgtQosjaIc2zyAgAOJT9A= Date: Mon, 12 Jun 2017 00:18:29 +0000 Message-ID: <6F87890CF0F5204F892DEA1EF0D77A59725BF227@FMSMSX114.amr.corp.intel.com> References: <1496750118-5570-1-git-send-email-rajmohan.mani@intel.com> <1496750118-5570-3-git-send-email-rajmohan.mani@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5C0It0G010247 Content-Length: 427 Lines: 15 Hi Linus, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > +static inline struct tps68470_gpio_data *to_gpio_data(struct > > +gpio_chip *gpiochp) { > > + return container_of(gpiochp, struct tps68470_gpio_data, gc); } > > Please use the data pointe inside gpio_chip. > My bad. I completely missed the following line. Will fix it v3. > struct tps68470_gpio_data *foo = gpiochip_get_data(gc); >