From: Masaki Ota <masaki.ota@jp.alps.com>
To: Laura Abbott <labbott@redhat.com>,
        Paul Donohue <linux-kernel@PaulSD.com>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Pali Rohar <pali.rohar@gmail.com>,
        Nick Fletcher <nick.m.fletcher@gmail.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "scott.s.lowe@gmail.com" <scott.s.lowe@gmail.com>
Subject: RE: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS -
 fix V8+ protocol handling (73 03 28)")
Thread-Topic: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS -
 fix V8+ protocol handling (73 03 28)")
Thread-Index: AQHS28lZ6isdvv9kdkG/gMORaIsZVqIShTyAgAWPoYCACKbrMA==
Date: Mon, 12 Jun 2017 05:25:28 +0000
Message-ID: <KAWPR01MB1092C3572946C54C2CC4DEFBC7CD0@KAWPR01MB1092.jpnprd01.prod.outlook.com>
References: <937d0082-5c51-e0b5-dcf9-efade5ecbde5@redhat.com>
 <20170603040349.GB16345@TopQuark.net>
 <e841f28c-4d63-170a-482f-8ef1deda1900@redhat.com>
In-Reply-To: <e841f28c-4d63-170a-482f-8ef1deda1900@redhat.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2017 05:25:28.1963
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 57e76998-77bd-4b82-a424-198f46eb2254
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KAWPR01MB1090
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5C5Plsq024879
Content-Length: 2544
Lines: 61

Hi, Laura,

Could you try to check below modification?
https://bugzilla.kernel.org/show_bug.cgi?id=195215#c10

This thread person said, the issue was fixed by this change.
I guess it's a XY coordinate setting problem, though the code that before the patch is applied also has a problem.

Best Regards,
Masaki Ota
-----Original Message-----
From: Laura Abbott [mailto:labbott@redhat.com] 
Sent: Wednesday, June 07, 2017 1:59 AM
To: Paul Donohue <linux-kernel@PaulSD.com>
Cc: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>; Dmitry Torokhov <dmitry.torokhov@gmail.com>; Pali Rohar <pali.rohar@gmail.com>; Nick Fletcher <nick.m.fletcher@gmail.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; scott.s.lowe@gmail.com
Subject: Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

On 06/02/2017 09:03 PM, Paul Donohue wrote:
> This might be related to 
> https://bugzilla.kernel.org/show_bug.cgi?id=195215
> 
> Could you have the user try this change? 
> https://bugzilla.kernel.org/show_bug.cgi?id=195215#c12
> 

https://bugzilla.redhat.com/show_bug.cgi?id=1447327#c13

"Cursor movement seems to work, but there are intermittent two-finger scrolling issues on the right-hand side of the touchpad. There are no issues with cursor movement or two-finger scrolling on the left-hand side of the touchpad."

> On Fri, Jun 02, 2017 at 10:54:52AM -0700, Laura Abbott wrote:
>> Hi,
>>
>> Fedora got a bug report 
>> https://bugzilla.redhat.com/show_bug.cgi?id=1447327
>> of a touchpad failure on a Dell Latitude E7370. Testing showed that 
>> the bad commit was
>>
>> commit e7348396c6d51b57c95c6646c390cd078e038e19
>> Author: Masaki Ota <masaki.ota@jp.alps.com>
>> Date:   Fri Mar 17 14:10:57 2017 -0700
>>
>>     Input: ALPS - fix V8+ protocol handling (73 03 28)
>>     
>>     Devices identified as E7="73 03 28" use slightly modified version of V8
>>     protocol, with lower count per electrode, different offsets, and different
>>     feature bits in OTP data.
>>     
>>     Fixes: aeaa881f9b17 ("Input: ALPS - set DualPoint flag for 74 03 28 devices")
>>     Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com>
>>     Acked-by: Pali Rohar <pali.rohar@gmail.com>
>>     Tested-by: Paul Donohue <linux-kernel@PaulSD.com>
>>     Tested-by: Nick Fletcher <nick.m.fletcher@gmail.com>
>>     Cc: stable@vger.kernel.org
>>     Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>
>> I suspect this particular model needs special handling as well?
>>
>> Thanks,
>> Laura
>>