Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbdFLHuI (ORCPT ); Mon, 12 Jun 2017 03:50:08 -0400 Received: from mga07.intel.com ([134.134.136.100]:31093 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751918AbdFLHuF (ORCPT ); Mon, 12 Jun 2017 03:50:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,332,1493708400"; d="scan'208";a="111989174" Date: Mon, 12 Jun 2017 10:50:01 +0300 From: Jarkko Sakkinen To: "Shaikh, Azhar" Cc: "jgunthorpe@obsidianresearch.com" , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" Subject: Re: [PATCH v4] tpm: Enable CLKRUN protocol for Braswell systems Message-ID: <20170612075001.56tayed7dmmk55hn@intel.com> References: <1496369044-38234-1-git-send-email-azhar.shaikh@intel.com> <1496965593-187931-1-git-send-email-azhar.shaikh@intel.com> <20170610111339.ggphrkwqiez35wer@intel.com> <5FFFAD06ADE1CA4381B3F0F7C6AF58289117D8@ORSMSX109.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF58289117D8@ORSMSX109.amr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2294 Lines: 62 On Sat, Jun 10, 2017 at 04:35:50PM +0000, Shaikh, Azhar wrote: > > > > -----Original Message----- > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com] > > Sent: Saturday, June 10, 2017 4:14 AM > > To: Shaikh, Azhar > > Cc: jgunthorpe@obsidianresearch.com; tpmdd-devel@lists.sourceforge.net; > > linux-kernel@vger.kernel.org; linux-security-module@vger.kernel.org > > Subject: Re: [PATCH v4] tpm: Enable CLKRUN protocol for Braswell systems > > > > On Thu, Jun 08, 2017 at 04:46:33PM -0700, Azhar Shaikh wrote: > > > To overcome a hardware limitation on Intel Braswell systems, disable > > > CLKRUN protocol during TPM transactions and re-enable once the > > > transaction is completed. > > > > > > Signed-off-by: Azhar Shaikh > > > --- > > > Changes from v1: > > > - Add CONFIG_X86 around disable_lpc_clk_run () and > > > enable_lpc_clk_run() to avoid > > > - build breakage on architectures which do not implement > > > kmap_atomic_pfn() > > > > > > Changes from v2: > > > - Use ioremap()/iounmap() instead of > > kmap_atomic_pfn()/kunmap_atomic() > > > - Move is_bsw() and all macros from tpm.h to tpm_tis.c file. > > > - Add the is_bsw() check in disable_lpc_clk_run() and > > > enable_lpc_clk_run() > > > - instead of adding it in each read/write API. > > > > > > Changes from v3: > > > - Move the code under #ifdef CONFIG_X86 and create stub functions for > > > everything else > > > - Rename the functions disable_lpc_clk_run() -> > > > tpm_platform_begin_xfer() and > > > - enable_lpc_clk_run() -> tpm_platform_end_xfer() > > > - Remove wmb() > > > > The wrong parameter order in outb() is not worth of mentioning in your > > opinion? > > > > Oh yes! It is definitely worth mentioning. I forgot to mention that. > Will definitely mention it in the changelog for the next version if any or will re send v4 with updated changelog for v3. > > > Related. > > > > I looked again the kmap version of the patch and still cannot figure out what > > could be wrong. Obviously the wrong outb() cause unexpected behavior. > > > > Do you have chances to grab klog from kmap version with correct outb? > > > > I have not tried the kmap version with corrected outb(). Will give that a try. > > > /Jarkko Thank you! /Jarkko