Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752033AbdFLIUo (ORCPT ); Mon, 12 Jun 2017 04:20:44 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:34520 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbdFLIUm (ORCPT ); Mon, 12 Jun 2017 04:20:42 -0400 Date: Mon, 12 Jun 2017 09:20:38 +0100 From: Lee Jones To: "Mani, Rajmohan" Cc: Sakari Ailus , Andy Shevchenko , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Linus Walleij , Alexandre Courbot , "Rafael J. Wysocki" , Len Brown Subject: Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Message-ID: <20170612082038.x6z3rx2bknxmfyfp@dell> References: <1496750118-5570-1-git-send-email-rajmohan.mani@intel.com> <1496750118-5570-2-git-send-email-rajmohan.mani@intel.com> <20170607115827.GY1019@valkosipuli.retiisi.org.uk> <6F87890CF0F5204F892DEA1EF0D77A59725BECB0@FMSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6F87890CF0F5204F892DEA1EF0D77A59725BECB0@FMSMSX114.amr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 39 On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > Hi Andy, > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > > wrote: > > > > The TPS68470 device is an advanced power management unit that powers > > > > a Compact Camera Module (CCM), generates clocks for image sensors, > > > > drives a dual LED for Flash and incorporates two LED drivers for > > > > general purpose indicators. > > > > > > > > This patch adds support for TPS68470 mfd device. > > > > > > I dunno why you decide to send this out now, see my comments below. > > > > > > > +static int tps68470_chip_init(struct tps68470 *tps) { > > > > + unsigned int version; > > > > + int ret; > > > > > > > + /* FIXME: configure these dynamically */ > > > > > > So, what prevents you to fix this? > > > > Nothing I suppose. They're however not needed right now and can be > > implemented later on if they're ever needed. > > > > Ack What does this mean? Is the plan to fix it or not? I don't want FIXMEs in the code that a) can be fixed right away or b) might never be fixed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog