Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057AbdFLIdp (ORCPT ); Mon, 12 Jun 2017 04:33:45 -0400 Received: from mx6.bahnhof.se ([213.80.101.16]:52303 "EHLO mx6.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbdFLIdm (ORCPT ); Mon, 12 Jun 2017 04:33:42 -0400 X-Greylist: delayed 1578 seconds by postgrey-1.27 at vger.kernel.org; Mon, 12 Jun 2017 04:33:40 EDT X-Spam-Score: 1.045 Message-ID: <593E4B82.70306@gaisler.com> Date: Mon, 12 Jun 2017 10:06:26 +0200 From: Andreas Larsson Organization: Cobham Gaisler AB User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Christoph Hellwig , x86@kernel.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH 27/44] sparc: remove leon_dma_ops References: <20170608132609.32662-1-hch@lst.de> <20170608132609.32662-28-hch@lst.de> In-Reply-To: <20170608132609.32662-28-hch@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 447 Lines: 16 On 2017-06-08 15:25, Christoph Hellwig wrote: > We can just use pci32_dma_ops. > > Btw, given that leon is 32-bit and appears to be PCI based, do even need > the special case for it in get_arch_dma_ops at all? Hi! Yes, it is needed. LEON systems are AMBA bus based. The common case here is DMA over AMBA buses. Some LEON systems have PCI bridges, but in general CONFIG_PCI is not a given. -- Andreas Larsson Software Engineer Cobham Gaisler