Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbdFLIgr (ORCPT ); Mon, 12 Jun 2017 04:36:47 -0400 Received: from gloria.sntech.de ([95.129.55.99]:49026 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbdFLIgp (ORCPT ); Mon, 12 Jun 2017 04:36:45 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: jeffy Cc: Shawn Lin , linux-kernel@vger.kernel.org, broonie@kernel.org, Mark Rutland , devicetree@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] spi: rockchip: add support for "cs-gpios" dts property Date: Mon, 12 Jun 2017 10:36:38 +0200 Message-ID: <4418523.E0t9k04HOG@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <593E501F.5060906@rock-chips.com> References: <1497248057-16550-1-git-send-email-jeffy.chen@rock-chips.com> <593E501F.5060906@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1955 Lines: 58 Am Montag, 12. Juni 2017, 16:26:07 CEST schrieb jeffy: > Hi Shawn, > > On 06/12/2017 03:15 PM, Shawn Lin wrote: > > Hi Jeffy, > > > > On 2017/6/12 14:14, Jeffy Chen wrote: > >> Support using "cs-gpios" property to specify cs gpios. > >> > >> Signed-off-by: Jeffy Chen > >> --- > >> > >> .../devicetree/bindings/spi/spi-rockchip.txt | 2 + > >> drivers/spi/spi-rockchip.c | 52 > >> > >> ++++++++++++++++++++++ > >> > >> 2 files changed, 54 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> index 83da493..02171b2 100644 > >> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > > > > The changes for doc should be another patch, and... > > but i saw others didn't separate them: > cf9e478 spi: sh-msiof: Add slave mode support > 23e291c spi: rockchip: support "sleep" pin configuration it sometimes falls through the cracks, but having dt-binding patches separate is meant to make it easier on DT-Maintainers to find patches they need to look at. > >> + if (!data->cs_gpio_requested) { > >> + ret = gpio_request_one(spi->cs_gpio, flags, > >> + dev_name(&spi->dev)); > >> + if (!ret) > >> + data->cs_gpio_requested = 1; > >> + } else > >> + ret = gpio_direction_output(spi->cs_gpio, flags); > > > > need brace around 'else' statement. Also I don't see data used > > elsewhere, so you need these code above. > > ok. > and the cs_gpio_requested is to mark cs_gpio requested, because the > setup func might be called multiple times, we only need to request gpio > at the first time. Aren't the gpiod* functions meant to be used for new things? Also you might actually do a bit of error handling there, especially EPROBE_DEFER. Heiko