Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbdFLJQF (ORCPT ); Mon, 12 Jun 2017 05:16:05 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:35060 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbdFLJQC (ORCPT ); Mon, 12 Jun 2017 05:16:02 -0400 MIME-Version: 1.0 In-Reply-To: <6F87890CF0F5204F892DEA1EF0D77A59725BF43C@FMSMSX114.amr.corp.intel.com> References: <1497161395-36504-1-git-send-email-rajmohan.mani@intel.com> <1497161395-36504-2-git-send-email-rajmohan.mani@intel.com> <6F87890CF0F5204F892DEA1EF0D77A59725BF43C@FMSMSX114.amr.corp.intel.com> From: Andy Shevchenko Date: Mon, 12 Jun 2017 12:16:01 +0300 Message-ID: Subject: Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470 To: "Mani, Rajmohan" Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Lee Jones , Linus Walleij , Alexandre Courbot , "Rafael J. Wysocki" , Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 331 Lines: 14 On Mon, Jun 12, 2017 at 12:12 PM, Mani, Rajmohan wrote: >> > +#include >> >> And this is for...? > use by tps68470.c which uses i2c_driver and other such i2c defines. It should be in C-file, not in the header which has nothing to do with I2C APIs. -- With Best Regards, Andy Shevchenko