Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbdFLJnC (ORCPT ); Mon, 12 Jun 2017 05:43:02 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:34411 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752405AbdFLJnA (ORCPT ); Mon, 12 Jun 2017 05:43:00 -0400 Message-ID: <1497260577.3086.11.camel@baylibre.com> Subject: Re: [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART nodes From: Jerome Brunet To: Neil Armstrong , gregkh@linuxfoundation.org, khilman@baylibre.com Cc: hgkr.klein@gmail.com, linux-serial@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Mon, 12 Jun 2017 11:42:57 +0200 In-Reply-To: <1497001756-942-6-git-send-email-narmstrong@baylibre.com> References: <1497001756-942-1-git-send-email-narmstrong@baylibre.com> <1497001756-942-6-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 55 On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote: > Switch to the stable UART bindings by adding a XTAL node and using the > proper compatible strings. > > Signed-off-by: Neil Armstrong Shouldn't this patch be squashed with patch 4 ? > --- >  arch/arm/boot/dts/meson6.dtsi | 28 ++++++++++++++++++++++++++++ >  1 file changed, 28 insertions(+) > > diff --git a/arch/arm/boot/dts/meson6.dtsi b/arch/arm/boot/dts/meson6.dtsi > index b0fc91f..a334fbe 100644 > --- a/arch/arm/boot/dts/meson6.dtsi > +++ b/arch/arm/boot/dts/meson6.dtsi > @@ -70,9 +70,37 @@ >   }; >   }; >   > + xtal: xtal-clk { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + clock-output-names = "xtal"; > + #clock-cells = <0>; > + }; > + >   clk81: clk@0 { >   #clock-cells = <0>; >   compatible = "fixed-clock"; >   clock-frequency = <200000000>; >   }; >  }; /* end of / */ > + > + > +&uart_AO { > + clocks = <&xtal>, <&clk81>, <&clk81>; > + clock-names = "xtal", "pclk", "baud"; > +}; > + > +&uart_A { > + clocks = <&xtal>, <&clk81>, <&clk81>; > + clock-names = "xtal", "pclk", "baud"; > +}; > + > +&uart_B { > + clocks = <&xtal>, <&clk81>, <&clk81>; > + clock-names = "xtal", "pclk", "baud"; > +}; > + > +&uart_C { > + clocks = <&xtal>, <&clk81>, <&clk81>; > + clock-names = "xtal", "pclk", "baud"; > +};