Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbdFLJsE (ORCPT ); Mon, 12 Jun 2017 05:48:04 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:35935 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752108AbdFLJsC (ORCPT ); Mon, 12 Jun 2017 05:48:02 -0400 Message-ID: <1497260879.3086.13.camel@baylibre.com> Subject: Re: [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes From: Jerome Brunet To: Neil Armstrong , gregkh@linuxfoundation.org, khilman@baylibre.com Cc: hgkr.klein@gmail.com, linux-serial@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Mon, 12 Jun 2017 11:47:59 +0200 In-Reply-To: <1497001756-942-8-git-send-email-narmstrong@baylibre.com> References: <1497001756-942-1-git-send-email-narmstrong@baylibre.com> <1497001756-942-8-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1854 Lines: 65 On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote: > Switch to the stable UART bindings by adding a XTAL node and using the > proper compatible strings. > > Signed-off-by: Neil Armstrong > --- >  arch/arm/boot/dts/meson8b.dtsi | 23 +++++++++++++++++++---- >  1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi > index d9f116a..651ad4a 100644 > --- a/arch/arm/boot/dts/meson8b.dtsi > +++ b/arch/arm/boot/dts/meson8b.dtsi > @@ -82,6 +82,13 @@ >   reg = <0x203>; >   }; >   }; > + > + xtal: xtal-clk { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + clock-output-names = "xtal"; > + #clock-cells = <0>; > + }; On meson8b, I think xtal is already provided by <&clkc CLKID_XTAL>. We have to choose which one we want. With this handled: Acked-by: Jerome Brunet >  }; /* end of / */ >   >  &aobus { > @@ -178,17 +185,25 @@ >  }; >   >  &uart_AO { > - clocks = <&clkc CLKID_CLK81>; > + compatible = "amlogic,meson8b-uart", "amlogic,meson-ao-uart"; > + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>; > + clock-names = "xtal", "pclk", "baud"; >  }; >   >  &uart_A { > - clocks = <&clkc CLKID_CLK81>; > + compatible = "amlogic,meson8b-uart"; > + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>; > + clock-names = "xtal", "pclk", "baud"; >  }; >   >  &uart_B { > - clocks = <&clkc CLKID_CLK81>; > + compatible = "amlogic,meson8b-uart"; > + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>; > + clock-names = "xtal", "pclk", "baud"; >  }; >   >  &uart_C { > - clocks = <&clkc CLKID_CLK81>; > + compatible = "amlogic,meson8b-uart"; > + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>; > + clock-names = "xtal", "pclk", "baud"; >  };