Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752584AbdFLJwl (ORCPT ); Mon, 12 Jun 2017 05:52:41 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7406 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbdFLJwk (ORCPT ); Mon, 12 Jun 2017 05:52:40 -0400 Subject: Re: [PATCH v3 0/4] Add support for ThunderX2 pmu events using json files To: Ganapatrao Kulkarni , , References: <1494923619-18687-1-git-send-email-ganapatrao.kulkarni@cavium.com> CC: , , , , , , , , From: Zhangshaokun Message-ID: Date: Mon, 12 Jun 2017 17:49:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1494923619-18687-1-git-send-email-ganapatrao.kulkarni@cavium.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.220.143] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.593E63C1.0019,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 97defe267973988a5be0546477d6cbdc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1991 Lines: 47 Hi Ganapat This patchset has been tested on Hisilicon's hip08 board for implementation defined PMU events: (1)perf list command is ok; (2)perf stat command -e event_name: When event number is less than 0x3ff, it is ok; if event number is more than 0x3ff, it should be added this patch: https://www.spinics.net/lists/arm-kernel/msg583222.html Thanks. Shaokun On 2017/5/16 16:33, Ganapatrao Kulkarni wrote: > Extending json/jevent framework for parsing arm64 event files. > Adding jevents for ThunderX2 implementation defined PMU events. > > v3: > - Addressed comments from Will Deacon and Jayachandran C. > - Rebased to 4.12-rc1 > > v2: > - Updated as per Mark Rutland's suggestions. > - Added provision for get_cpuid_str to get cpu id string > from associated cpus of pmu core device. > > v1: Initial patchset. > > Ganapatrao Kulkarni (4): > perf utils: passing pmu as a parameter to function get_cpuid_str > perf tools arm64: Add support for get_cpuid_str function. > perf utils: Add helper function is_pmu_core to detect PMU CORE devices > perf vendor events arm64: Add ThunderX2 implementation defined pmu > core events > > tools/perf/arch/arm64/util/Build | 1 + > tools/perf/arch/arm64/util/header.c | 59 ++++++++++++++++++++ > tools/perf/arch/powerpc/util/header.c | 2 +- > tools/perf/arch/x86/util/header.c | 2 +- > tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ > .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ > tools/perf/util/header.h | 3 +- > tools/perf/util/pmu.c | 53 +++++++++++++++--- > 8 files changed, 186 insertions(+), 11 deletions(-) > create mode 100644 tools/perf/arch/arm64/util/header.c > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json >