Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752179AbdFLMC3 (ORCPT ); Mon, 12 Jun 2017 08:02:29 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35782 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdFLMC1 (ORCPT ); Mon, 12 Jun 2017 08:02:27 -0400 Date: Mon, 12 Jun 2017 14:02:23 +0200 From: Krzysztof Kozlowski To: Arvind Yadav Cc: stern@rowland.harvard.edu, kgene@kernel.org, javier@osg.samsung.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable Message-ID: <20170612120223.GA11300@kozik-book> References: <3aa745c2cea5b8a91d10f898bc201121001a9a0b.1497265923.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3aa745c2cea5b8a91d10f898bc201121001a9a0b.1497265923.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 375 Lines: 13 On Mon, Jun 12, 2017 at 04:45:14PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ehci-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof