Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262390AbTFJGyo (ORCPT ); Tue, 10 Jun 2003 02:54:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262400AbTFJGyo (ORCPT ); Tue, 10 Jun 2003 02:54:44 -0400 Received: from AMarseille-201-1-2-177.w193-253.abo.wanadoo.fr ([193.253.217.177]:23591 "EHLO gaston") by vger.kernel.org with ESMTP id S262390AbTFJGyo (ORCPT ); Tue, 10 Jun 2003 02:54:44 -0400 Subject: Re: [PATCH] IDE Power Management, try 3 From: Benjamin Herrenschmidt To: Bartlomiej Zolnierkiewicz Cc: Jens Axboe , linux-kernel mailing list In-Reply-To: <200306062325.23317.bzolnier@elka.pw.edu.pl> References: <200306062325.23317.bzolnier@elka.pw.edu.pl> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Message-Id: <1055228889.641.35.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.4 Date: 10 Jun 2003 09:08:09 +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 20 On Fri, 2003-06-06 at 23:25, Bartlomiej Zolnierkiewicz wrote: > I have corrected it a bit and I am going to submit it, any comments? > > Ben, can you verify my changes and check that it still works after 'fixing'? > :-) Heh, thanks for the "corrections" ;) Regarding ide_wait_not_busy(), I'd rather have it return -ENODEV when it reads 0xff, what do you think ? I'll test the patch later today (just back from a long week-end), Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/