Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbdFLOBE (ORCPT ); Mon, 12 Jun 2017 10:01:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44068 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954AbdFLOBD (ORCPT ); Mon, 12 Jun 2017 10:01:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD4577F6A1 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rgb@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BD4577F6A1 Date: Mon, 12 Jun 2017 10:00:45 -0400 From: Richard Guy Briggs To: Derek Robson Cc: paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] audit: style fix Message-ID: <20170612140044.GD21241@madcap2.tricolour.ca> References: <20170612023303.3700-1-robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170612023303.3700-1-robsonde@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 12 Jun 2017 14:01:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3769 Lines: 95 On 2017-06-12 14:33, Derek Robson wrote: > Fixed checkpatch.pl warnings of "function definition argument FOO > should also have an identifier name" > > Signed-off-by: Derek Robson Sounds reasonable. Reviewed-by: Richard Guy Briggs > --- > kernel/audit.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/kernel/audit.h b/kernel/audit.h > index ddfce2ea4891..90b891eea204 100644 > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -247,13 +247,13 @@ struct audit_netlink_list { > struct sk_buff_head q; > }; > > -int audit_send_list(void *); > +int audit_send_list(void *_dest); > > extern int selinux_audit_rule_update(void); > > extern struct mutex audit_filter_mutex; > -extern int audit_del_rule(struct audit_entry *); > -extern void audit_free_rule_rcu(struct rcu_head *); > +extern int audit_del_rule(struct audit_entry *entry); > +extern void audit_free_rule_rcu(struct rcu_head *head); > extern struct list_head audit_filter_list[]; > > extern struct audit_entry *audit_dupe_rule(struct audit_krule *old); > @@ -301,17 +301,17 @@ extern int audit_exe_compare(struct task_struct *tsk, struct audit_fsnotify_mark > #endif /* CONFIG_AUDIT_WATCH */ > > #ifdef CONFIG_AUDIT_TREE > -extern struct audit_chunk *audit_tree_lookup(const struct inode *); > -extern void audit_put_chunk(struct audit_chunk *); > -extern bool audit_tree_match(struct audit_chunk *, struct audit_tree *); > -extern int audit_make_tree(struct audit_krule *, char *, u32); > -extern int audit_add_tree_rule(struct audit_krule *); > -extern int audit_remove_tree_rule(struct audit_krule *); > +extern struct audit_chunk *audit_tree_lookup(const struct inode *inode); > +extern void audit_put_chunk(struct audit_chunk *chunk); > +extern bool audit_tree_match(struct audit_chunk *chunk, struct audit_tree *tree); > +extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op); > +extern int audit_add_tree_rule(struct audit_krule *rule); > +extern int audit_remove_tree_rule(struct audit_krule *rule); > extern void audit_trim_trees(void); > extern int audit_tag_tree(char *old, char *new); > -extern const char *audit_tree_path(struct audit_tree *); > -extern void audit_put_tree(struct audit_tree *); > -extern void audit_kill_trees(struct list_head *); > +extern const char *audit_tree_path(struct audit_tree *tree); > +extern void audit_put_tree(struct audit_tree *tree); > +extern void audit_kill_trees(struct list_head *list); > #else > #define audit_remove_tree_rule(rule) BUG() > #define audit_add_tree_rule(rule) -EINVAL > @@ -323,7 +323,7 @@ extern void audit_kill_trees(struct list_head *); > #define audit_kill_trees(list) BUG() > #endif > > -extern char *audit_unpack_string(void **, size_t *, size_t); > +extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len); > > extern pid_t audit_sig_pid; > extern kuid_t audit_sig_uid; > @@ -333,7 +333,7 @@ extern int audit_filter(int msgtype, unsigned int listtype); > > #ifdef CONFIG_AUDITSYSCALL > extern int audit_signal_info(int sig, struct task_struct *t); > -extern void audit_filter_inodes(struct task_struct *, struct audit_context *); > +extern void audit_filter_inodes(struct task_struct *tsk, struct audit_context *ctx); > extern struct list_head *audit_killed_trees(void); > #else > #define audit_signal_info(s,t) AUDIT_DISABLED > -- > 2.13.0 > > -- > Linux-audit mailing list > Linux-audit@redhat.com > https://www.redhat.com/mailman/listinfo/linux-audit - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635