Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbdFLOJm (ORCPT ); Mon, 12 Jun 2017 10:09:42 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:35754 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752089AbdFLOJk (ORCPT ); Mon, 12 Jun 2017 10:09:40 -0400 Date: Mon, 12 Jun 2017 10:09:39 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Arvind Yadav cc: kgene@kernel.org, , , , , , , Subject: Re: [PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable In-Reply-To: <3aa745c2cea5b8a91d10f898bc201121001a9a0b.1497265923.git.arvind.yadav.cs@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 26 On Mon, 12 Jun 2017, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ehci-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c > index 7a603f6..26b6411 100644 > --- a/drivers/usb/host/ehci-exynos.c > +++ b/drivers/usb/host/ehci-exynos.c > @@ -279,7 +279,9 @@ static int exynos_ehci_resume(struct device *dev) > struct exynos_ehci_hcd *exynos_ehci = to_exynos_ehci(hcd); > int ret; > > - clk_prepare_enable(exynos_ehci->clk); > + ret = clk_prepare_enable(exynos_ehci->clk); > + if (ret) > + return ret; > > ret = exynos_ehci_phy_enable(dev); > if (ret) { Acked-by: Alan Stern