Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752402AbdFLOao (ORCPT ); Mon, 12 Jun 2017 10:30:44 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:36383 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbdFLOam (ORCPT ); Mon, 12 Jun 2017 10:30:42 -0400 MIME-Version: 1.0 In-Reply-To: <20170612153752.3b71516c@karo-electronics.de> References: <7055ce6095c0b7f026ac6f0dc37e43fc5c0b1793.1496939031.git.leonard.crestez@nxp.com> <1497005895.28352.88.camel@nxp.com> <20170609154638.3b64e6d0@karo-electronics.de> <1497022484.28352.105.camel@nxp.com> <20170612124029.1643469d@karo-electronics.de> <1497268028.32422.15.camel@nxp.com> <20170612153752.3b71516c@karo-electronics.de> From: Fabio Estevam Date: Mon, 12 Jun 2017 11:30:41 -0300 Message-ID: Subject: Re: [PATCH 2/2] ARM: dts: imx6ul: Add imx6ul-tempmon To: =?UTF-8?Q?Lothar_Wa=C3=9Fmann?= Cc: Leonard Crestez , Bai Ping , "linux-pm@vger.kernel.org" , Shawn Guo , linux-kernel , Eduardo Valentin , Sascha Hauer , Fabio Estevam , Zhang Rui , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5CEUsJq014306 Content-Length: 1171 Lines: 28 On Mon, Jun 12, 2017 at 10:37 AM, Lothar Waßmann wrote: > Hi, > > On Mon, 12 Jun 2017 10:22:45 -0300 Fabio Estevam wrote: >> On Mon, Jun 12, 2017 at 8:47 AM, Leonard Crestez >> wrote: >> >> > However it seems that this might be accidental, it just happens that >> > the OCOTP clock starts as enabled and is only disabled later in the >> >> Most likely because U-Boot enabled the OCOTP clock as it reads the >> speed grading fuse. >> > No, the imx6q_opp_check_speed_grading() runs on an i.MX6Q which, as > mentioned in my other mail <20170612124029.1643469d@karo-electronics.de>, > does not require any clock to be enabled for accessing the OCOTP regs. [Sorry I removed the list in my previous response by mistake] What I was trying to say is that the OCOTP clock is enabled by U-Boot on mx6ul evk board. Please check: http://git.denx.de/?p=u-boot.git;a=blob;f=board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c;h=a5746fe08688d5752bf1d69cff465a355404d6da;hb=HEAD#l833 This would explain why Leonard did not see the kernel hang on his test. So I agree with you that the thermal driver needs the IMX6UL_CLK_OCOTP too.