DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C741123983
Date: Mon, 12 Jun 2017 12:25:39 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Amey Telawane <ameyt@codeaurora.org>,
        Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH 4.11 145/150] tracing: Use strlcpy() instead of strcpy()
 in __trace_find_cmdline()
Message-ID: <20170612122539.32096f48@gandalf.local.home>
In-Reply-To: <20170612160500.GB24926@kroah.com>
References: <20170612152519.404936272@linuxfoundation.org>
        <20170612152526.131874759@linuxfoundation.org>
        <20170612113707.2bcf59ea@gandalf.local.home>
        <20170612160500.GB24926@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 32

On Mon, 12 Jun 2017 18:05:00 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> > Link: http://lkml.kernel.org/r/1493806274-13936-1-git-send-email-amit.pundir@linaro.org

> Hm, Amit asked me to merge all of these for some reason.  I guess people
> see the "oh, look, strcpy is bad!" and jump to wrong conclusions.

I said the same thing when accepting it. From the thread that is
referenced by the Link tag:

https://marc.info/?l=linux-kernel&m=149382004318095&w=2

"Note, I don't see anyway to trigger a bug. To me this looks simply like
someone saw "strcpy" and said to themselves "oh this is a bug", when
actuality it is not. I don't mind the extra security added, but I don't
think this even needs to go to stable. The reason is that the comm used
within the kernel is always created by the kernel, and always has a
terminating nul character. There's other places in the kernel that will
bug if that is not true."

-- Steve


> 
> {sigh}
> 
> Amit, can I drop these and you will not get upset?
> 
> thanks,
> 
> greg k-h