Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754633AbdFLQj2 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Jun 2017 12:39:28 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54740 "EHLO
        mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752044AbdFLQj0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Jun 2017 12:39:26 -0400
Date: Mon, 12 Jun 2017 17:38:56 +0100
From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com
Message-ID: <20170612163856.vctl42rg674r72bj@sirena.org.uk>
References: <1497280672-24011-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ohtysf4fxbribuc6"
Content-Disposition: inline
In-Reply-To: <1497280672-24011-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
X-Cookie: <doogie> dpkg has bugs?  no way!
User-Agent: NeoMutt/20170306 (1.8.0)
X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH] regulator: core: Prioritise consumer mappings over
 regulator name
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 854
Lines: 29


--ohtysf4fxbribuc6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 12, 2017 at 04:17:52PM +0100, Charles Keepax wrote:

>  	r = regulator_lookup_by_name(supply);
> -	if (r)
> -		return r;

Why have you left the lookup here?

--ohtysf4fxbribuc6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlk+w58ACgkQJNaLcl1U
h9BCyAf7Bn3pb1RlaYxOCvaZarzs5ZL6YGiXhbGSJ2px5UwpPml8bMViBIXaBo3i
ftd/r3zwKggXkm0C/Nzt9QEd80ZGyGnLKcaVa5BiLGKu+O5pOsodTJCC0zL1L7iz
w6LIKz+k/qt6HAVgrC+OJgz9qsoEZK0D9fAfk6YtX+fuINvNOX6z5GCY8b5OArSj
KkSQN5H42qTIhUHJfL6Z+PhHVrcPdMLYfxCYKKM+ZFXNnUtJ+1FZekxJ5Mu0fRSe
/pxXZ3HaDjFikfe4ZRO9UQDVkjZ3xjtn3f+M/ZTujI4mMm/OuoNffIOXnfZeCYoj
1KneMELpujMLVtIAREeTYcloZBvzdQ==
=nzNV
-----END PGP SIGNATURE-----

--ohtysf4fxbribuc6--