Date: Tue, 10 Jun 2003 14:26:14 +0100
From: Christoph Hellwig <hch@infradead.org>
To: =?iso-8859-1?Q?P=E1sztor_Szil=E1rd?= <silicon@inf.bme.hu>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
       Adrian Bunk <bunk@fs.tum.de>
Subject: Re: [2.5 patch] let COMX depend on PROC_FS
Message-ID: <20030610142614.A25666@infradead.org>
Mail-Followup-To: Christoph Hellwig <hch@infradead.org>,
	=?iso-8859-1?Q?P=E1sztor_Szil=E1rd?= <silicon@inf.bme.hu>,
	linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
	Adrian Bunk <bunk@fs.tum.de>
References: <20030608175850.A9513@infradead.org> <Pine.GSO.4.00.10306101347450.1700-100000@kempelen.iit.bme.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <Pine.GSO.4.00.10306101347450.1700-100000@kempelen.iit.bme.hu>; from silicon@inf.bme.hu on Tue, Jun 10, 2003 at 01:55:22PM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 916
Lines: 17

On Tue, Jun 10, 2003 at 01:55:22PM +0200, P?sztor Szil?rd wrote:
> The drivers are used by some hundreds of cards today but we tell users to
> get the small kernelpatch from www.itc.hu and the patch, among other things,
> exports proc_get_inode. There was a process to integrate the patch into the
> mainstream kernel last year but, due to lack of time on my part, it was
> suspended. I hope to be able to pick the line up again and clean things up.

So what about fixing it instead?  The usage of proc_get_inode is broken
and so is the whole profs mess in the comx driver.  If you want to keep
the API you need to add a ramfs-style filesystem instead of abusing
procfs.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/