Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbdFLStJ (ORCPT ); Mon, 12 Jun 2017 14:49:09 -0400 Received: from mail-yw0-f176.google.com ([209.85.161.176]:35375 "EHLO mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbdFLStH (ORCPT ); Mon, 12 Jun 2017 14:49:07 -0400 Date: Mon, 12 Jun 2017 14:49:04 -0400 From: Tejun Heo To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com, rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com, Shaohua Li Subject: Re: [PATCH 08/11] block: always attach cgroup info into bio Message-ID: <20170612184904.GL19206@htj.duckdns.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 422 Lines: 16 On Fri, Jun 02, 2017 at 02:54:01PM -0700, Shaohua Li wrote: > @@ -691,6 +691,8 @@ static inline bool blkcg_bio_issue_check(struct request_queue *q, > rcu_read_lock(); > blkcg = bio_blkcg(bio); > > + bio_associate_blkcg(bio, &blkcg->css); > + Let's please note that this only established the fallback mapping when the bio hasn't been associated yet and doesn't override the existing association. Thanks. -- tejun