Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbdFLU5P (ORCPT ); Mon, 12 Jun 2017 16:57:15 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:41003 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbdFLU5O (ORCPT ); Mon, 12 Jun 2017 16:57:14 -0400 Date: Mon, 12 Jun 2017 13:57:11 -0700 From: Guenter Roeck To: Jaya Durga Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue Message-ID: <20170612205711.GA28052@roeck-us.net> References: <1497206646-20998-1-git-send-email-jayad@cdac.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497206646-20998-1-git-send-email-jayad@cdac.in> User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 36 On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote: > Fixed WARNING: line over 80 characters > > Signed-off-by: Jaya Durga > --- > drivers/staging/rtl8712/ieee80211.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > 1.9.1 > > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c > index 6e673c1..97ef063 100644 > --- a/drivers/staging/rtl8712/ieee80211.c > +++ b/drivers/staging/rtl8712/ieee80211.c > @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv) > sz += 8; > ie += sz; > /*beacon interval : 2bytes*/ > - *(__le16 *)ie = cpu_to_le16( > - (u16)pdev_network->configuration.beacon_period); > + struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration; > + *(__le16 *)ie = cpu_to_le16(cfg->beacon_period); Do you really think that the resulting drivers/staging/rtl8712/ieee80211.c:177:2: warning: ISO C90 forbids mixed declarations and code is better ? Guenter > sz += 2; > ie += 2; > /*capability info*/