Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995AbdFLWod (ORCPT ); Mon, 12 Jun 2017 18:44:33 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:34956 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752647AbdFLWoc (ORCPT ); Mon, 12 Jun 2017 18:44:32 -0400 Date: Tue, 13 Jun 2017 00:44:26 +0200 (CEST) From: Thomas Gleixner To: Anju T Sudhakar cc: mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com, bsingharora@gmail.com, anton@samba.org, sukadev@linux.vnet.ibm.com, mikey@neuling.org, stewart@linux.vnet.ibm.com, dja@axtens.net, eranian@google.com, hemant@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com Subject: Re: [PATCH v9 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging In-Reply-To: <692e037d-5367-208f-ac6f-8fd43e1643ba@linux.vnet.ibm.com> Message-ID: References: <1496665922-702-1-git-send-email-anju@linux.vnet.ibm.com> <1496665922-702-2-git-send-email-anju@linux.vnet.ibm.com> <692e037d-5367-208f-ac6f-8fd43e1643ba@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 21 On Wed, 7 Jun 2017, Anju T Sudhakar wrote: > On Tuesday 06 June 2017 03:39 PM, Thomas Gleixner wrote: > > On Mon, 5 Jun 2017, Anju T Sudhakar wrote: > > > +static void cleanup_all_core_imc_memory(struct imc_pmu *pmu_ptr) > > > +{ > > > + struct imc_mem_info *ptr = pmu_ptr->mem_info; > > > + > > > + if (!ptr) > > > + return; > > That's pointless. > > No, it is not. We may end up here from imc_mem_init() when the memory > allocation for pmu_ptr->mem_info fails. So in that case we can just > return from here, and kfree wont be called with a NULL pointer. What's the problem with that. kfree() CAN be called with a NULL pointer. It has a check already. Thanks, tglx