Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbdFMBMV (ORCPT ); Mon, 12 Jun 2017 21:12:21 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35998 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752508AbdFMBMU (ORCPT ); Mon, 12 Jun 2017 21:12:20 -0400 To: Colin King Cc: qla2xxx-upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170605172958.12844-1-colin.king@canonical.com> Date: Mon, 12 Jun 2017 21:12:07 -0400 In-Reply-To: <20170605172958.12844-1-colin.king@canonical.com> (Colin King's message of "Mon, 5 Jun 2017 18:29:58 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 376 Lines: 12 Colin, > An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove redundant > wait when target is stopped.") removed a null check on ha->tgt.tgt_ops > and replaced it with a new check that null checked tgt, thus making > the subsequent null check on tgt totally redundant. Remove it. Applied to 4.13/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering