Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbdFMC1d (ORCPT ); Mon, 12 Jun 2017 22:27:33 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:50655 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbdFMC1c (ORCPT ); Mon, 12 Jun 2017 22:27:32 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.59 with qID v5D2RLa1009372, This message is accepted by code: ctloc85258 From: Hayes Wang To: Oliver Neukum , "netdev@vger.kernel.org" CC: nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net-next 1/2] r8152: split rtl8152_resume function Thread-Topic: [PATCH net-next 1/2] r8152: split rtl8152_resume function Thread-Index: AQHS41Tp65+N/fuZMk6tY1v+bjzbDaIgo2YAgAFsZxA= Date: Tue, 13 Jun 2017 02:27:20 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB201A5E4ED@RTITMBSV06.realtek.com.tw> References: <1394712342-15778-272-Taiwan-albertk@realtek.com> <1394712342-15778-273-Taiwan-albertk@realtek.com> <1497270806.15677.18.camel@suse.com> In-Reply-To: <1497270806.15677.18.camel@suse.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.120] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5D2Rm3d032396 Content-Length: 425 Lines: 14 Oliver Neukum [mailto:oneukum@suse.com] > Sent: Monday, June 12, 2017 8:33 PM [...] > > +               usb_submit_urb(tp->intr_urb, GFP_KERNEL); > > If you ever built a device with included storage, this can deadlock, > as you may want to wake up a device for memory that is needed to wake > up a device. Use GFP_NOIO in resume() and reset_resume(), always. I would change it. Thanks. Best Regards, Hayes