Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbdFMCiK (ORCPT ); Mon, 12 Jun 2017 22:38:10 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36129 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbdFMCiI (ORCPT ); Mon, 12 Jun 2017 22:38:08 -0400 Date: Tue, 13 Jun 2017 10:38:18 +0800 From: Dong Aisheng To: kbuild test robot Cc: Dong Aisheng , kbuild-all@01.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, jslaby@suse.com, fugang.duan@nxp.com, stefan@agner.ch, Mingkai.Hu@nxp.com, yangbo.lu@nxp.com, nikita.yoush@cogentembedded.com, andy.shevchenko@gmail.com, fengguang.wu@intel.com Subject: Re: [PATCH] tty: serial: lpuart: fix semicolon.cocci warnings Message-ID: <20170613023818.GB15770@b29396-OptiPlex-7040> References: <201706130841.YZhbOH9x%fengguang.wu@intel.com> <20170613002841.GA25353@lkp-wsm-ep1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170613002841.GA25353@lkp-wsm-ep1> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1526 Lines: 60 Hi Fengguang, On Tue, Jun 13, 2017 at 08:28:41AM +0800, kbuild test robot wrote: > drivers/tty/serial/fsl_lpuart.c:305:2-3: Unneeded semicolon > > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Dong Aisheng > Signed-off-by: Fengguang Wu Seems not catched by checkpatch. > --- > > fsl_lpuart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -302,7 +302,7 @@ static inline void lpuart32_write(struct > case UPIO_MEM32BE: > iowrite32be(val, port->membase + off); > break; > - }; > + } lpuart32_read needs the same fixing. diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index a66ed23..ed0bf18 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -288,7 +288,7 @@ static inline u32 lpuart32_read(struct uart_port *port, u32 off) return ioread32be(port->membase + off); default: return 0; - }; + } } static inline void lpuart32_write(struct uart_port *port, u32 val, @@ -301,7 +301,7 @@ static inline void lpuart32_write(struct uart_port *port, u32 val, case UPIO_MEM32BE: iowrite32be(val, port->membase + off); break; - }; + } } Thanks for the catching. Regards Dong Aisheng > } > > static void lpuart_stop_tx(struct uart_port *port)