DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C18CC6073A
From: Kalle Valo <kvalo@codeaurora.org>
To: Caesar Wang <wxt@rock-chips.com>
Cc: amitkarwar@gmail.com, huxm@marvell.com, nishants@marvell.com,
        gbhat@marvell.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        briannorris@chromium.org, jeffy.chen@rock-chips.com
Subject: Re: [PATCH] mwifiex: fixes the trivial print
References: <1497008411-15223-1-git-send-email-wxt@rock-chips.com>
Date: Tue, 13 Jun 2017 09:28:23 +0300
In-Reply-To: <1497008411-15223-1-git-send-email-wxt@rock-chips.com> (Caesar
        Wang's message of "Fri, 9 Jun 2017 19:40:11 +0800")
Message-ID: <87poe8pfjs.fsf@purkki.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1780
Lines: 56

Caesar Wang <wxt@rock-chips.com> writes:

> We have always met the unused log be printed as following.
>
> ...
> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2    & channel=13 freq=0
> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2    & channel=13 freq=0
>
> Maybe that's related to wifi regdom, since wifi default area
> was US and didn't support 12~14 channels.
>
> As Frequencies:
> * 2412 MHz [1] (30.0 dBm)
> * 2417 MHz [2] (30.0 dBm)
> * 2422 MHz [3] (30.0 dBm)
> * 2427 MHz [4] (30.0 dBm)
> * 2432 MHz [5] (30.0 dBm)
> * 2437 MHz [6] (30.0 dBm)
> * 2442 MHz [7] (30.0 dBm)
> * 2447 MHz [8] (30.0 dBm)
> * 2452 MHz [9] (30.0 dBm)
> * 2457 MHz [10] (30.0 dBm)
> * 2462 MHz [11] (30.0 dBm)
> * 2467 MHz [12] (disabled)
> * 2472 MHz [13] (disabled)
> * 2484 MHz [14] (disabled)
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
>  drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c
> index 1ff2205..6e29943 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq)
>  		}
>  	}
>  	if (i == sband->n_channels) {
> -		mwifiex_dbg(priv->adapter, ERROR,
> +		mwifiex_dbg(priv->adapter, WARN,
>  			    "%s: cannot find cfp by band %d\t"
>  			    "& channel=%d freq=%d\n",
>  			    __func__, band, channel, freq);

I don't see how this fixes anything, care to explain? And the title is
quite vague.

And I would rather fix the root cause, mwifiex folks please comment.

-- 
Kalle Valo