Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbdFMGyk (ORCPT ); Tue, 13 Jun 2017 02:54:40 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:53572 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbdFMGyi (ORCPT ); Tue, 13 Jun 2017 02:54:38 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: jeffy.chen@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] mwifiex: fixes the trivial print To: Kalle Valo Cc: amitkarwar@gmail.com, huxm@marvell.com, nishants@marvell.com, gbhat@marvell.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, jeffy.chen@rock-chips.com References: <1497008411-15223-1-git-send-email-wxt@rock-chips.com> <87poe8pfjs.fsf@purkki.adurom.net> From: Caesar Wang Message-ID: Date: Tue, 13 Jun 2017 14:54:15 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <87poe8pfjs.fsf@purkki.adurom.net> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2082 Lines: 67 Kalle, ?? 2017??06??13?? 14:28, Kalle Valo ะด??: > Caesar Wang writes: > >> We have always met the unused log be printed as following. >> >> ... >> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >> cannot find cfp by band 2 & channel=13 freq=0 >> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >> cannot find cfp by band 2 & channel=13 freq=0 >> >> Maybe that's related to wifi regdom, since wifi default area >> was US and didn't support 12~14 channels. >> >> As Frequencies: >> * 2412 MHz [1] (30.0 dBm) >> * 2417 MHz [2] (30.0 dBm) >> * 2422 MHz [3] (30.0 dBm) >> * 2427 MHz [4] (30.0 dBm) >> * 2432 MHz [5] (30.0 dBm) >> * 2437 MHz [6] (30.0 dBm) >> * 2442 MHz [7] (30.0 dBm) >> * 2447 MHz [8] (30.0 dBm) >> * 2452 MHz [9] (30.0 dBm) >> * 2457 MHz [10] (30.0 dBm) >> * 2462 MHz [11] (30.0 dBm) >> * 2467 MHz [12] (disabled) >> * 2472 MHz [13] (disabled) >> * 2484 MHz [14] (disabled) >> >> Signed-off-by: Caesar Wang >> --- >> >> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c >> index 1ff2205..6e29943 100644 >> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c >> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c >> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq) >> } >> } >> if (i == sband->n_channels) { >> - mwifiex_dbg(priv->adapter, ERROR, >> + mwifiex_dbg(priv->adapter, WARN, >> "%s: cannot find cfp by band %d\t" >> "& channel=%d freq=%d\n", >> __func__, band, channel, freq); > I don't see how this fixes anything, care to explain? And the title is > quite vague. Sorry for the description maybe unclear. I'm assuming the print log is expected for marvel wifi driver. Do we should use 'WARN' to instead of the 'ERROR' here. > > And I would rather fix the root cause, mwifiex folks please comment. Indeed, that's my expected. -Caesar >