Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbdFMHFN (ORCPT ); Tue, 13 Jun 2017 03:05:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46110 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbdFMHFL (ORCPT ); Tue, 13 Jun 2017 03:05:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A4694606DC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Caesar Wang Cc: amitkarwar@gmail.com, huxm@marvell.com, nishants@marvell.com, gbhat@marvell.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, jeffy.chen@rock-chips.com Subject: Re: [PATCH] mwifiex: fixes the trivial print References: <1497008411-15223-1-git-send-email-wxt@rock-chips.com> <87poe8pfjs.fsf@purkki.adurom.net> Date: Tue, 13 Jun 2017 10:04:36 +0300 In-Reply-To: (Caesar Wang's message of "Tue, 13 Jun 2017 14:54:15 +0800") Message-ID: <87mv9c74hn.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5D75NdG012418 Content-Length: 2171 Lines: 65 Caesar Wang writes: > Kalle, > > 在 2017年06月13日 14:28, Kalle Valo 写道: >> Caesar Wang writes: >> >>> We have always met the unused log be printed as following. >>> >>> ... >>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>> cannot find cfp by band 2 & channel=13 freq=0 >>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>> cannot find cfp by band 2 & channel=13 freq=0 >>> >>> Maybe that's related to wifi regdom, since wifi default area >>> was US and didn't support 12~14 channels. >>> >>> As Frequencies: >>> * 2412 MHz [1] (30.0 dBm) >>> * 2417 MHz [2] (30.0 dBm) >>> * 2422 MHz [3] (30.0 dBm) >>> * 2427 MHz [4] (30.0 dBm) >>> * 2432 MHz [5] (30.0 dBm) >>> * 2437 MHz [6] (30.0 dBm) >>> * 2442 MHz [7] (30.0 dBm) >>> * 2447 MHz [8] (30.0 dBm) >>> * 2452 MHz [9] (30.0 dBm) >>> * 2457 MHz [10] (30.0 dBm) >>> * 2462 MHz [11] (30.0 dBm) >>> * 2467 MHz [12] (disabled) >>> * 2472 MHz [13] (disabled) >>> * 2484 MHz [14] (disabled) >>> >>> Signed-off-by: Caesar Wang >>> --- >>> >>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c >>> index 1ff2205..6e29943 100644 >>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c >>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c >>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq) >>> } >>> } >>> if (i == sband->n_channels) { >>> - mwifiex_dbg(priv->adapter, ERROR, >>> + mwifiex_dbg(priv->adapter, WARN, >>> "%s: cannot find cfp by band %d\t" >>> "& channel=%d freq=%d\n", >>> __func__, band, channel, freq); >> I don't see how this fixes anything, care to explain? And the title is >> quite vague. > > Sorry for the description maybe unclear. > I'm assuming the print log is expected for marvel wifi driver. Do we > should use 'WARN' to instead of the 'ERROR' here. But does that make any functional difference, isn't the warning still printed? -- Kalle Valo