Date: Tue, 13 Jun 2017 09:28:29 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Amey Telawane <ameyt@codeaurora.org>,
        Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH 4.11 145/150] tracing: Use strlcpy() instead of strcpy()
 in __trace_find_cmdline()
Message-ID: <20170613072829.GA15006@kroah.com>
References: <20170612152519.404936272@linuxfoundation.org>
 <20170612152526.131874759@linuxfoundation.org>
 <20170612113707.2bcf59ea@gandalf.local.home>
 <20170612160500.GB24926@kroah.com>
 <20170612122539.32096f48@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170612122539.32096f48@gandalf.local.home>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1123
Lines: 26

On Mon, Jun 12, 2017 at 12:25:39PM -0400, Steven Rostedt wrote:
> On Mon, 12 Jun 2017 18:05:00 +0200
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > > Link: http://lkml.kernel.org/r/1493806274-13936-1-git-send-email-amit.pundir@linaro.org
> 
> > Hm, Amit asked me to merge all of these for some reason.  I guess people
> > see the "oh, look, strcpy is bad!" and jump to wrong conclusions.
> 
> I said the same thing when accepting it. From the thread that is
> referenced by the Link tag:
> 
> https://marc.info/?l=linux-kernel&m=149382004318095&w=2
> 
> "Note, I don't see anyway to trigger a bug. To me this looks simply like
> someone saw "strcpy" and said to themselves "oh this is a bug", when
> actuality it is not. I don't mind the extra security added, but I don't
> think this even needs to go to stable. The reason is that the comm used
> within the kernel is always created by the kernel, and always has a
> terminating nul character. There's other places in the kernel that will
> bug if that is not true."

Ok, I've now dropped this patch from all stable queues, sorry for the
noise.

greg k-h