Subject: Re: [PATCH v3 15/18] xen/pvcalls: implement the ioworker functions
To: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xen.org
Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com,
        Stefano Stabellini <stefano@aporeto.com>
References: <alpine.DEB.2.10.1706021225440.18759@sstabellini-ThinkPad-X260>
 <1496431915-20774-1-git-send-email-sstabellini@kernel.org>
 <1496431915-20774-15-git-send-email-sstabellini@kernel.org>
From: Juergen Gross <jgross@suse.com>
Message-ID: <51e3bbad-d5f2-a3b9-b038-4535cd58ea2a@suse.com>
Date: Tue, 13 Jun 2017 09:51:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1496431915-20774-15-git-send-email-sstabellini@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2032
Lines: 66

On 02/06/17 21:31, Stefano Stabellini wrote:
> We have one ioworker per socket. Each ioworker goes through the list of
> outstanding read/write requests. Once all requests have been dealt with,
> it returns.
> 
> We use one atomic counter per socket for "read" operations and one
> for "write" operations to keep track of the reads/writes to do.
> 
> We also use one atomic counter ("io") per ioworker to keep track of how
> many outstanding requests we have in total assigned to the ioworker. The
> ioworker finishes when there are none.
> 
> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> CC: boris.ostrovsky@oracle.com
> CC: jgross@suse.com
> ---
>  drivers/xen/pvcalls-back.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index 6afe7a0..0283d49 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -99,8 +99,35 @@ static int pvcalls_back_release_active(struct xenbus_device *dev,
>  				       struct pvcalls_fedata *priv,
>  				       struct sock_mapping *map);
>  
> +static void pvcalls_conn_back_read(unsigned long opaque)

Why not void *opaque? You could drop the cast below then.


Juergen

> +{
> +}
> +
> +static int pvcalls_conn_back_write(struct sock_mapping *map)
> +{
> +	return 0;
> +}
> +
>  static void pvcalls_back_ioworker(struct work_struct *work)
>  {
> +	struct pvcalls_ioworker *ioworker = container_of(work,
> +		struct pvcalls_ioworker, register_work);
> +	struct sock_mapping *map = container_of(ioworker, struct sock_mapping,
> +		ioworker);
> +
> +	while (atomic_read(&map->io) > 0) {
> +		if (atomic_read(&map->release) > 0) {
> +			atomic_set(&map->release, 0);
> +			return;
> +		}
> +
> +		if (atomic_read(&map->read) > 0)
> +			pvcalls_conn_back_read((unsigned long)map);
> +		if (atomic_read(&map->write) > 0)
> +			pvcalls_conn_back_write(map);
> +
> +		atomic_dec(&map->io);
> +	}
>  }
>  
>  static int pvcalls_back_socket(struct xenbus_device *dev,
>