Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbdFMJY5 (ORCPT ); Tue, 13 Jun 2017 05:24:57 -0400 Received: from mail-yb0-f196.google.com ([209.85.213.196]:34538 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbdFMJYy (ORCPT ); Tue, 13 Jun 2017 05:24:54 -0400 MIME-Version: 1.0 In-Reply-To: <20170613091913.GA24844@kroah.com> References: <1497336734-19368-1-git-send-email-tal.shorer@gmail.com> <1497336734-19368-7-git-send-email-tal.shorer@gmail.com> <20170613091913.GA24844@kroah.com> From: Tal Shorer Date: Tue, 13 Jun 2017 12:24:53 +0300 Message-ID: Subject: Re: [PATCH v2 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding To: Greg KH Cc: linux-doc@vger.kernel.org, "" , USB list , balbi@kernel.org, Jonathan Corbet Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 18 On Tue, Jun 13, 2017 at 12:19 PM, Greg KH wrote: > On Tue, Jun 13, 2017 at 09:52:12AM +0300, Tal Shorer wrote: >> The user can issue USB_F_GET_LINE_CODING to get the current line coding >> as set by the host (or the default if unset yet). >> >> Signed-off-by: Tal Shorer >> --- >> Documentation/ioctl/ioctl-number.txt | 1 + >> drivers/usb/gadget/function/f_acm.c | 19 +++++++++++++++++++ >> include/uapi/linux/usb/f_acm.h | 12 ++++++++++++ > > Where is this ioctl being called? On the tty device? If so, which one? > The gadget driver's tty device node? Or somewhere else? On an acm ttyGS* fd, yes. > > confused at the different levels here, sorry. > > greg k-h