Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752349AbdFMJcW (ORCPT ); Tue, 13 Jun 2017 05:32:22 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:59203 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbdFMJcU (ORCPT ); Tue, 13 Jun 2017 05:32:20 -0400 Reply-To: kieran.bingham@ideasonboard.com Subject: Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver References: <865b71d4fcf6ce407a94a10d5dcb06944ddb6dcb.1497313626.git-series.kieran.bingham+renesas@ideasonboard.com> To: Geert Uytterhoeven , Kieran Bingham Cc: Linux Media Mailing List , Linux-Renesas , "linux-kernel@vger.kernel.org" , Laurent Pinchart , Sakari Ailus , =?UTF-8?Q?Niklas_S=c3=b6derlund?= From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Tue, 13 Jun 2017 10:32:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2244 Lines: 72 On 13/06/17 10:24, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide support for the ADV7481 and ADV7482. >> >> The driver is modelled with 4 subdevices to allow simultaneous streaming >> from the AFE (Analog front end) and HDMI inputs though two CSI TX >> entities. >> >> The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked >> to the TXB CSI bus. >> >> The driver is based on a prototype by Koji Matsuoka in the Renesas BSP, >> and an earlier rework by Niklas Söderlund. >> >> Signed-off-by: Kieran Bingham > >> --- /dev/null >> +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c > >> +static int adv748x_hdmi_set_pixelrate(struct adv748x_hdmi *hdmi) >> +{ >> + struct v4l2_subdev *tx; >> + struct v4l2_dv_timings timings; >> + struct v4l2_bt_timings *bt = &timings.bt; >> + unsigned int fps; >> + >> + tx = adv748x_get_remote_sd(&hdmi->pads[ADV748X_HDMI_SOURCE]); >> + if (!tx) >> + return -ENOLINK; >> + >> + adv748x_hdmi_query_dv_timings(&hdmi->sd, &timings); >> + >> + fps = DIV_ROUND_CLOSEST(bt->pixelclock, >> + V4L2_DV_BT_FRAME_WIDTH(bt) * >> + V4L2_DV_BT_FRAME_HEIGHT(bt)); > > On arm32: > > drivers/built-in.o: In function `adv748x_hdmi_set_pixelrate': > :(.text+0x1b8b1c): undefined reference to `__aeabi_uldivmod' > > v4l2_bt_timings.pixelclock is u64, so you should use DIV_ROUND_CLOSEST_ULL() > instead. Aha, thanks. /me ponders why I didn't get spammed from the bot-builders about this? Fix applied locally ready for v5. Would you like the remote updated for renesas-drivers or will you patch locally? -- Kieran > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >