Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbdFMJi7 (ORCPT ); Tue, 13 Jun 2017 05:38:59 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:34310 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbdFMJi5 (ORCPT ); Tue, 13 Jun 2017 05:38:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <865b71d4fcf6ce407a94a10d5dcb06944ddb6dcb.1497313626.git-series.kieran.bingham+renesas@ideasonboard.com> From: Geert Uytterhoeven Date: Tue, 13 Jun 2017 11:38:54 +0200 X-Google-Sender-Auth: Dn_L9qndOW65_n7QQWwjYSJ5s5g Message-ID: Subject: Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver To: Kieran Bingham Cc: Kieran Bingham , Linux Media Mailing List , Linux-Renesas , "linux-kernel@vger.kernel.org" , Laurent Pinchart , Sakari Ailus , =?UTF-8?Q?Niklas_S=C3=B6derlund?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5D9d8SY002417 Content-Length: 2483 Lines: 73 Hi Kieran, On Tue, Jun 13, 2017 at 11:32 AM, Kieran Bingham wrote: > On 13/06/17 10:24, Geert Uytterhoeven wrote: >> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: >>> From: Kieran Bingham >>> >>> Provide support for the ADV7481 and ADV7482. >>> >>> The driver is modelled with 4 subdevices to allow simultaneous streaming >>> from the AFE (Analog front end) and HDMI inputs though two CSI TX >>> entities. >>> >>> The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked >>> to the TXB CSI bus. >>> >>> The driver is based on a prototype by Koji Matsuoka in the Renesas BSP, >>> and an earlier rework by Niklas Söderlund. >>> >>> Signed-off-by: Kieran Bingham >> >>> --- /dev/null >>> +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c >> >>> +static int adv748x_hdmi_set_pixelrate(struct adv748x_hdmi *hdmi) >>> +{ >>> + struct v4l2_subdev *tx; >>> + struct v4l2_dv_timings timings; >>> + struct v4l2_bt_timings *bt = &timings.bt; >>> + unsigned int fps; >>> + >>> + tx = adv748x_get_remote_sd(&hdmi->pads[ADV748X_HDMI_SOURCE]); >>> + if (!tx) >>> + return -ENOLINK; >>> + >>> + adv748x_hdmi_query_dv_timings(&hdmi->sd, &timings); >>> + >>> + fps = DIV_ROUND_CLOSEST(bt->pixelclock, >>> + V4L2_DV_BT_FRAME_WIDTH(bt) * >>> + V4L2_DV_BT_FRAME_HEIGHT(bt)); >> >> On arm32: >> >> drivers/built-in.o: In function `adv748x_hdmi_set_pixelrate': >> :(.text+0x1b8b1c): undefined reference to `__aeabi_uldivmod' >> >> v4l2_bt_timings.pixelclock is u64, so you should use DIV_ROUND_CLOSEST_ULL() >> instead. > > Aha, thanks. > > /me ponders why I didn't get spammed from the bot-builders about this? -EBUSY? > Fix applied locally ready for v5. > > Would you like the remote updated for renesas-drivers or will you patch locally? I'll patch it locally just to avoid receiving more spam from the builders soon (we don't use adv748x on arm32 boards). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds