Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531AbdFMJmH (ORCPT ); Tue, 13 Jun 2017 05:42:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54960 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbdFMJmG (ORCPT ); Tue, 13 Jun 2017 05:42:06 -0400 Date: Tue, 13 Jun 2017 11:41:57 +0200 From: Greg KH To: Jia-Ju Bai Cc: wporter82@gmail.com, sergio.paracuellos@gmail.com, aquannie@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rts5208: Fix a sleep-in-atomic bug in sd_send_cmd_get_rsp Message-ID: <20170613094157.GI5677@kroah.com> References: <1496626296-27953-1-git-send-email-baijiaju1990@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496626296-27953-1-git-send-email-baijiaju1990@163.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 27 On Mon, Jun 05, 2017 at 09:31:36AM +0800, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > rtsx_exclusive_enter_ss (acquire the lock by spin_lock) > rtsx_enter_ss > rtsx_power_off_card > sd_cleanup_work > sd_stop_seq_mode > sd_switch_clock > sd_ddr_tuning > sd_ddr_pre_tuning_tx > sd_send_cmd_get_rsp > wait_timeout > schedule_timeout --> may sleep > > To fix it, "wait_timeout" is replaced with mdelay in sd_send_cmd_get_rsp. > > Signed-off-by: Jia-Ju Bai > --- > drivers/staging/rts5208/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You sent 3 copies of this patch, and I have no idea which to take. Please fix up and resend the _one_ that is correct. thanks, greg k-h