Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263398AbTFJQXU (ORCPT ); Tue, 10 Jun 2003 12:23:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263407AbTFJQXU (ORCPT ); Tue, 10 Jun 2003 12:23:20 -0400 Received: from mion.elka.pw.edu.pl ([194.29.160.35]:56730 "EHLO mion.elka.pw.edu.pl") by vger.kernel.org with ESMTP id S263398AbTFJQXT (ORCPT ); Tue, 10 Jun 2003 12:23:19 -0400 Date: Tue, 10 Jun 2003 18:36:41 +0200 (MET DST) From: Bartlomiej Zolnierkiewicz To: Benjamin Herrenschmidt cc: Jens Axboe , Alan Cox , linux-kernel mailing list Subject: Re: [PATCH] IDE Power Management, try 2 In-Reply-To: <1055262472.705.21.camel@gaston> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 29 On 10 Jun 2003, Benjamin Herrenschmidt wrote: > On Tue, 2003-06-10 at 18:15, Jens Axboe wrote: > > On Thu, Jun 05 2003, Bartlomiej Zolnierkiewicz wrote: > > > Jens, I think generic version of ide_do_drive_cmd() would be useful for > > > other block devices, what do you think? > > > > Something ala this? Completely untested, and I only did scsi_ioctl.c and > > ide-io.c. iirc, scsi uses somthing similar that could be adapted too. > > Hrm... you didn't keep some functionalities I added with the PM > patch here... like marking of preempt requests so I can fetch them > even when drive is blocked, and ide_head_wait... > > Ben I've looked for users of ide_preempt in drivers/ide/ and I think that REQ_PREEMPT can later die if we fix drivers to correctly mark sense requests with REQ_SENSE... -- Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/