Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbdFMJuH (ORCPT ); Tue, 13 Jun 2017 05:50:07 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:27832 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751891AbdFMJuF (ORCPT ); Tue, 13 Jun 2017 05:50:05 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="19974706" Subject: Re: [PATCH v2] Kbuild: tiny correction on `make help` To: Masahiro Yamada References: <1496740073-3320-1-git-send-email-caoj.fnst@cn.fujitsu.com> CC: Linux Kernel Mailing List , Linux Kbuild mailing list , Michal Marek From: Cao jin Message-ID: <593FB5F2.4040206@cn.fujitsu.com> Date: Tue, 13 Jun 2017 17:52:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.69] X-yoursite-MailScanner-ID: 0E76C46B53EA.AC879 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caoj.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 40 Yamada-san, I have a question on the current top level Makefile. There are following lines, I have trouble to understand "firstword x$(MAKEFLAGS)" in 2nd line, why there is a 'x' there? ifneq ($(filter 4.%,$(MAKE_VERSION)),) # make-4 ifneq ($(filter %s ,$(firstword x$(MAKEFLAGS))),) quiet=silent_ tools_silent=s endif else # make-3.8x ifneq ($(filter s% -s%,$(MAKEFLAGS)),) quiet=silent_ tools_silent=-s endif endif I already read & understand your patch[*] and know these lines will be modified, but I have spent quite a few days on understanding it, so I still want to know the purpose of 'x'. [*]https://lkml.org/lkml/2017/5/19/371 -- Sincerely, Cao jin On 06/06/2017 11:01 PM, Masahiro Yamada wrote: > 2017-06-06 18:07 GMT+09:00 Cao jin : >> The help info of `make C=1` is little confusing, make it clear. >> >> Signed-off-by: Cao jin > > > Applied to linux-kbuild/fixes. Thanks! >