Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753053AbdFMKEH (ORCPT ); Tue, 13 Jun 2017 06:04:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55514 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbdFMKEF (ORCPT ); Tue, 13 Jun 2017 06:04:05 -0400 Date: Tue, 13 Jun 2017 12:03:58 +0200 From: Greg KH To: Ioana Radulescu Cc: devel@driverdev.osuosl.org, stuyoder@gmail.com, arnd@arndb.de, linux-kernel@vger.kernel.org, agraf@suse.de, Bharat.Bhushan@nxp.com, bogdan.purcareata@nxp.com, linux-arm-kernel@lists.infradead.org, laurentiu.tudor@nxp.com Subject: Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields Message-ID: <20170613100358.GA11444@kroah.com> References: <20170606150041.10955-1-ruxandra.radulescu@nxp.com> <20170606150041.10955-16-ruxandra.radulescu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606150041.10955-16-ruxandra.radulescu@nxp.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 396 Lines: 15 On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote: > Reorder fields in the device's private structure such that > the ones most used on the hotpath are at the beginning of > the structure. > > This brings a small performance improvement due to better > cache usage. Really? What kind of performance improvement? Always be specific. Please fix up and resend. thanks, greg k-h